Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: reduce the execution of reflect and decode #46421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

net/rpc: reduce the execution of reflect and decode #46421

wants to merge 1 commit into from
+4 −4

Conversation

lcr2000
Copy link
Contributor

@lcr2000 lcr2000 commented May 27, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 27, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: e3b8a60) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/323014 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323014.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323014.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323014.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 18, 2022
@lcr2000 @ianlancetaylor
net/rpc: reduce the execution of reflect and decode
3d7392a 
Change-Id: Ief4b5e1c2d1002392901124c0694afe58c271573
GitHub-Last-Rev: e3b8a60
GitHub-Pull-Request: #46421
Reviewed-on: https://go-review.googlesource.com/c/go/+/323014
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
Mifrill
Mifrill reviewed Nov 8, 2023
View reviewed changes
Copy link

@Mifrill Mifrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The safety of this change hinges on whether the subsequent code relies on the original sname value before the conditional assignment. In this specific instance, it does indeed depend on the previous sname. Consequently, I hold reservations about this modification and anticipate that it may result in failed tests on CI pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mifrill Mifrill Mifrill left review comments

Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lcr2000 @gopherbot @Mifrill