New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix error check messages for 2 types2 tests #46445
test: fix error check messages for 2 types2 tests #46445
Conversation
Many compiler tests fail with -G=3 due to changes in error message format. This commit fixes two of these tests, to ensure I am on the right track in review.
This PR (HEAD: 42d981c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/323314 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Matthew Dempsky: Patch Set 1: Run-TryBot+1 Trust+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Go Bot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Zachary Burkett: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Go Bot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Matthew Dempsky: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Many compiler tests fail with -G=3 due to changes in error message format. This commit fixes two of these tests, to ensure I am on the right track in review. Updates #46447
This PR (HEAD: 0ed904b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/323314 to see it. Tip: You can toggle comments from me using the |
Message from Zachary Burkett: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Matthew Dempsky: Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Go Bot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Message from Go Bot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
Many compiler tests fail with -G=3 due to changes in error message format. This commit fixes two of these tests, to ensure I am on the right track in review. Updates #46447 Change-Id: I138956d536a1d48ca9198e6ddbfde13865bb5dd5 GitHub-Last-Rev: 0ed904b GitHub-Pull-Request: #46445 Reviewed-on: https://go-review.googlesource.com/c/go/+/323314 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Robert Griesemer <gri@golang.org> Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org>
Message from Robert Griesemer: Patch Set 3: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/323314. |
This PR is being closed because golang.org/cl/323314 has been merged. |
Many compiler tests fail with -G=3 due to changes in error message format.
This commit fixes two of these tests, to ensure I am on the right track in review.
Updates #46447