Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: panic during export method expression [1.17 backport] #48102

Closed
gopherbot opened this issue Aug 31, 2021 · 2 comments
Closed

cmd/compile: panic during export method expression [1.17 backport] #48102

gopherbot opened this issue Aug 31, 2021 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.1

Comments

@gopherbot
Copy link

@cuonglm requested issue #48088 to be considered for backport to the next 1.17 minor release.

@gopherbot please open a backport to go1.17
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 31, 2021
@gopherbot gopherbot mentioned this issue Aug 31, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.1 milestone Aug 31, 2021
@cuonglm cuonglm changed the title cmd/compile: panic in escape analysis [1.17 backport] cmd/compile: panic during export method expression [1.17 backport] Aug 31, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/346670 mentions this issue: [release-branch.go1.17] cmd/compile: fix method expression lookup during import

@cherrymui cherrymui added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 1, 2021
@gopherbot
Copy link
Author

Closed by merging 3969694 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Sep 1, 2021
@cuonglm @cherrymui
[release-branch.go1.17] cmd/compile: fix method expression lookup dur…
3969694 
…ing import

CL 309831 fixed importing of method expressions, by re-using the same
code already have for ODOTMETH. But that code does not work with
embedded field.

To fix this, we need to calculate all methods of the receiver base type
of method expression, before looking up the selection.

Fixes #48102

Change-Id: Ia244d36a3ed0f989735eb57becdfa70a81912f57
Reviewed-on: https://go-review.googlesource.com/c/go/+/346489
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/346670
Reviewed-by: Keith Randall <khr@golang.org>
lmb added a commit to cloudflare/tubular that referenced this issue Feb 17, 2022
@lmb
pin to Go 1.16
1086d27 
Compiling with go 1.17 currently panics due to golang/go#48102

Pin to the latest 1.16 for the time being.
@golang golang locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.1
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui