Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/sha1: use math/bits.RotateLeft32 #49051

Closed
wants to merge 1 commit into from
Closed

crypto/sha1: use math/bits.RotateLeft32 #49051

wants to merge 1 commit into from

Conversation

AlexanderYastrebov
Copy link
Contributor

@AlexanderYastrebov AlexanderYastrebov commented Oct 19, 2021 •
edited

Updates #31456

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 19, 2021
@gopherbot
Copy link

This PR (HEAD: 8aee742) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/356516 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 1: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 17ea697) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/356516 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Alexander Yastrebov:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 3: Patch Set 2 was rebased

Copied Votes:

  • Code-Review+2 (copy condition: "changekind:NO_CHANGE OR is:ANY")

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 3: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 4: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 5: Patch Set 4 was rebased

Copied Votes:

  • Code-Review+2 (copy condition: "changekind:NO_CHANGE OR is:ANY")

Outdated Votes:

  • Auto-Submit+1 (copy condition: "changekind:NO_CHANGE")
  • Run-TryBot+1 (copy condition: "changekind:NO_CODE_CHANGE")
  • TryBot-Result-1 (copy condition: "changekind:NO_CODE_CHANGE")

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 5: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Heschi Kreinick:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Bryan Mills:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 6, 2023
@AlexanderYastrebov @gopherbot
crypto/sha1: use math/bits.RotateLeft32
677038f 
Updates #31456

Change-Id: I68e0abfb6771c9b1d1bfcbb642db9eb5540f9cab
GitHub-Last-Rev: 17ea697
GitHub-Pull-Request: #49051
Reviewed-on: https://go-review.googlesource.com/c/go/+/356516
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@gopherbot
Copy link

Message from Filippo Valsorda:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/356516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/356516 has been merged.

@gopherbot gopherbot closed this Feb 6, 2023
johanbrandhorst pushed a commit to Pryz/go that referenced this pull request Feb 12, 2023
@AlexanderYastrebov @johanbrandhorst
crypto/sha1: use math/bits.RotateLeft32
b3f821a 
Updates golang#31456

Change-Id: I68e0abfb6771c9b1d1bfcbb642db9eb5540f9cab
GitHub-Last-Rev: 17ea697
GitHub-Pull-Request: golang#49051
Reviewed-on: https://go-review.googlesource.com/c/go/+/356516
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
bassosimone pushed a commit to ooni/oocrypto that referenced this pull request Apr 8, 2024
@AlexanderYastrebov @gopherbot
crypto/sha1: use math/bits.RotateLeft32
c9d60af 
Updates #31456

Change-Id: I68e0abfb6771c9b1d1bfcbb642db9eb5540f9cab
GitHub-Last-Rev: 17ea697c5c0bbfdfb1ad91c2c60e22f6efc78b43
GitHub-Pull-Request: golang/go#49051
Reviewed-on: https://go-review.googlesource.com/c/go/+/356516
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexanderYastrebov @gopherbot