Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: add missing //go:nosplit for Windows context methods #49991

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

runtime: add missing //go:nosplit for Windows context methods #49991

wants to merge 1 commit into from
+24 −0

Conversation

honsunrise
Copy link

@honsunrise honsunrise commented Dec 6, 2021 •
edited

Avoid calling morestack when we handling exceptions.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 6, 2021
@gopherbot
Copy link

This PR (HEAD: e306436) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/369494 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Patrik Nyblom:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Michael Knyszek:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1: Code-Review+2

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@honsunrise honsunrise changed the title runtime: fix missing //go:nosplit for Windows context runtime: add missing //go:nosplit for Windows context methods Dec 7, 2021
@gopherbot
Copy link

This PR (HEAD: 53af3c4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/369494 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 3: Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Austin Clements:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Honsun Zhu:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/369494.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@honsunrise @gopherbot