Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: fix benchmark overflow #50023

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

testing: fix benchmark overflow #50023

wants to merge 3 commits into from
+33 −7

Conversation

lkxiaolou
Copy link

@lkxiaolou lkxiaolou commented Dec 7, 2021 •
edited
Loading

The original implementation could cause timeouts if a long benchmark was set and the test function took a short time, so float64 was used and overflow detection was added.

Fixes #49973

@lkxiaolou
Fix benchtime too long leads timeout :
d5e53fa 
1. handles overflows
2. add an unit test
@lkxiaolou lkxiaolou changed the title Fix#49973 benchtime too long leads timeout Fix #49973 benchtime too long leads timeout Dec 7, 2021
@lkxiaolou lkxiaolou mentioned this pull request Dec 7, 2021
Open
@gopherbot
Copy link
Contributor

This PR (HEAD: d5e53fa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/372395 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/372395.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: affbe96) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/372395 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@lkxiaolou lkxiaolou changed the title Fix #49973 benchtime too long leads timeout testing: fix benchmark overflow May 12, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: 999da1b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/372395 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing: benchmark timeout when benchtime set too long
2 participants
@lkxiaolou @gopherbot