Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/dns: Increase UDP response buffer to 1232 bytes #51128

Closed
wants to merge 1 commit into from

Conversation

AaronFriel
Copy link

This resolves #51127 in the near term by defaulting to a larger buffer
size. This is not a permanent fix or implementation of EDNS(0) or IETF
RFC6891 (https://datatracker.ietf.org/doc/html/rfc6891).

These changes should be reviewed by someone with more experience than I.

:)

Fixes #51127
^ hotfix only.

This resolves golang#51127 in the near term by defaulting to a larger buffer
size. This is not a permanent fix or implementation of EDNS(0) or [IETF
RFC6891](https://datatracker.ietf.org/doc/html/rfc6891).

These changes should be reviewed by someone with more experience than I.

:)

Signed-off-by: Aaron Friel <mayreply@aaronfriel.com>
@gopherbot
Copy link

This PR (HEAD: f3985f3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/384076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/384076.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/384076 has been abandoned.

Thanks. Let's use CL 385035 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net: 512 byte DNS response size limit causes "cannot unmarshal DNS" error
2 participants