New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http/httputil: reduce mem allocs for dummyBody client request dumps #51662
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 7293659) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/392514 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
This PR (HEAD: 35297ee) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/392514 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 7500230) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/392514 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: db9e26c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/392514 to see it. Tip: You can toggle comments from me using the |
Message from Sean McGrail: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Damien Neil: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Sean McGrail: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Damien Neil: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Sean McGrail: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Damien Neil: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Sean McGrail: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Message from Damien Neil: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/392514. |
Reduces the number of unnecessary memory allocations performed when dumping an HTTP client request excluding the body.
Simple benchmark: