New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: prevent panic in go work use #51845
Conversation
This PR (HEAD: 5bfdc9d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
This PR (HEAD: d256fca) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
Message from Michael Matloob: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Filippo Rossi: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Michael Matloob: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Filippo Rossi: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
This PR (HEAD: ac77f7c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 81208e4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
Message from Bryan Mills: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Filippo Rossi: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Bryan Mills: Patch Set 4: Code-Review+1 Trust+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
This PR (HEAD: 2d224ae) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
Message from Filippo Rossi: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Bryan Mills: Patch Set 5: Run-TryBot+1 Trust+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Gopher Robot: Patch Set 5: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Filippo Rossi: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
This PR (HEAD: 646dc3c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
Message from Bryan Mills: Patch Set 6: Run-TryBot+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Bryan Mills: Patch Set 6: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Emmanuel Odeke: Patch Set 6: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Emmanuel Odeke: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Check if paths passed as arguments are existing directories. Fixes golang#51841 Fixes golang#51749
This PR (HEAD: 77fffa7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/394154 to see it. Tip: You can toggle comments from me using the |
Message from Filippo Rossi: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Emmanuel Odeke: Patch Set 8: Run-TryBot+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Message from Gopher Robot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/394154. |
Check if paths passed as arguments are existing directories. Fixes #51841 Fixes #51749 Change-Id: Icfd148627e6f2c4651d6f923a37d413e68c67f6c GitHub-Last-Rev: 77fffa7 GitHub-Pull-Request: #51845 Reviewed-on: https://go-review.googlesource.com/c/go/+/394154 Trust: Bryan Mills <bcmills@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Trust: Emmanuel Odeke <emmanuel@orijtech.com> Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This PR is being closed because golang.org/cl/394154 has been merged. |
Check if paths passed as arguments are existing directories. Fixes #52140 Updates #51841 Change-Id: Icfd148627e6f2c4651d6f923a37d413e68c67f6c GitHub-Last-Rev: 77fffa7 GitHub-Pull-Request: #51845 Reviewed-on: https://go-review.googlesource.com/c/go/+/394154 Trust: Bryan Mills <bcmills@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Trust: Emmanuel Odeke <emmanuel@orijtech.com> Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/397995 Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Check if paths passed as arguments are existing directories.
Fixes #51841
Fixes #51749