New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/constraint: update doc to mention a feature added in Go 1.17 #53647
Conversation
This PR (HEAD: e68a1f0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/415774 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/415774. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415774. |
e68a1f0
to
a6e8811
Compare
The pkg documentation mentions that the "//go:build" syntax "will be" added in Go 1.17. In fact, it has been added in that Go release, so the documentation can now be updated.
a6e8811
to
4371886
Compare
This PR (HEAD: 4371886) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/415774 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415774. |
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/415774. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415774. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415774. |
The pkg documentation mentions that the "//go:build" syntax "will be" added in Go 1.17. In fact, it has been added in that Go release, so the documentation can now be updated. Change-Id: I72f24063c3be62d97ca78bf724d56599f5f19460 GitHub-Last-Rev: 4371886 GitHub-Pull-Request: #53647 Reviewed-on: https://go-review.googlesource.com/c/go/+/415774 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/415774 has been merged. |
The pkg documentation mentions that the "//go:build" syntax "will be" added in Go 1.17. In fact, it has been added in that Go release, so the documentation can now be updated. Change-Id: I72f24063c3be62d97ca78bf724d56599f5f19460 GitHub-Last-Rev: 4371886 GitHub-Pull-Request: golang#53647 Reviewed-on: https://go-review.googlesource.com/c/go/+/415774 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
The pkg documentation mentions that the "//go:build" syntax "will be"
added in Go 1.17. In fact, it has been added in that Go release, so the
documentation can now be updated.