Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: store combine on amd64 #54126

Closed
wants to merge 1 commit into from
Closed

cmd/compile: store combine on amd64 #54126

wants to merge 1 commit into from

Conversation

cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Jul 29, 2022 •
edited

Fixes #54120

@gopherbot
Copy link

This PR (HEAD: 98dcaf2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from xie cui:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: f1abf77) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 29a35a0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: a62fc3a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cuiweixie cuiweixie changed the title cmd/compile: store combining cmd/compile: store combine on amd64 Jul 30, 2022
@gopherbot
Copy link

Message from xie cui:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 8cd03b2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 3ae9814) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Keith Randall:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ben Shi:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 1265419) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: dbf9c30) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 798b465) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Keith Randall:

Patch Set 10: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 10: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Dmitri Shuralyov:

Patch Set 10: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Wayne Zuo:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 03f1994) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/420115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from xie cui:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Wayne Zuo:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 11: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Than McIntosh:

Patch Set 11: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/420115.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 8, 2022
@cuiweixie @randall77
cmd/compile: store combine on amd64
e730703 
Fixes #54120

Change-Id: I6915b6e8d459d9becfdef4fdcba95ee4dea6af05
GitHub-Last-Rev: 03f1994
GitHub-Pull-Request: #54126
Reviewed-on: https://go-review.googlesource.com/c/go/+/420115
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/420115 has been merged.

@gopherbot gopherbot closed this Aug 8, 2022
jproberts pushed a commit to jproberts/go that referenced this pull request Aug 10, 2022
@cuiweixie @jproberts
cmd/compile: store combine on amd64
e734321 
Fixes golang#54120

Change-Id: I6915b6e8d459d9becfdef4fdcba95ee4dea6af05
GitHub-Last-Rev: 03f1994
GitHub-Pull-Request: golang#54126
Reviewed-on: https://go-review.googlesource.com/c/go/+/420115
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/compile: store combining not complete
2 participants
@cuiweixie @gopherbot