Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: don't panic on very large MaxBytesReaderLimit #54415

Closed
wants to merge 1 commit into from

Conversation

cuiweixie
Copy link
Contributor

Fixes #54408

@gopherbot
Copy link

This PR (HEAD: ef98b52) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/423314 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 65e230f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/423314 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Damien Neil:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 0675bff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/423314 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@cuiweixie cuiweixie changed the title net/http: fix overflow net/http: don't panic on very large MaxBytesReaderLimit Aug 12, 2022
@gopherbot
Copy link

This PR (HEAD: a33fe7e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/423314 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from xie cui:

Patch Set 4:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Damien Neil:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from xie cui:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from hopehook:

Patch Set 4: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from David Chase:

Patch Set 4: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/423314.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 26, 2022
Fixes #54408

Change-Id: I454199ae5bcd087b8fc4169b7622412105e71113
GitHub-Last-Rev: a33fe7e
GitHub-Pull-Request: #54415
Reviewed-on: https://go-review.googlesource.com/c/go/+/423314
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: xie cui <523516579@qq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: hopehook <hopehook@qq.com>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/423314 has been merged.

@gopherbot gopherbot closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http/request: maxBytesReader.Read int64 overflow
2 participants