Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: Makes copies from JS to Go more efficient #55062

Closed

Conversation

codefromthecrypt
Copy link

This reduces impact of EOF or other short reads when GOOS=js.

Fixes #53566

@google-cla
Copy link

google-cla bot commented Sep 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link

This PR (HEAD: 2e5b7b2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Richard Musiol:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 07ead32) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Richard Musiol:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: e387021) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 6cf067f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 170f12e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 7941411) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Richard Musiol:

Patch Set 6: Run-TryBot+1

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 6:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 5ad770d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Richard Musiol:

Patch Set 7:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: f95c236) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Adrian Cole:

Patch Set 8:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: d9390db) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@codefromthecrypt codefromthecrypt changed the title syscall/js: Makes copies from JS to Go more efficient syscall: Makes copies from JS to Go more efficient Jan 2, 2023
@codefromthecrypt
Copy link
Author

note I renamed the title syscall/js to syscall even though other PRs use the former. Main hope is this can get it across the finish line.

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 10:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/430875.
After addressing review feedback, remember to publish your drafts!

This reduces impact of EOF or other short reads when `GOOS=js`.

Fixes golang#53566
@gopherbot
Copy link

This PR (HEAD: 50dbd82) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430875 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@codefromthecrypt codefromthecrypt deleted the fix-short-read branch August 8, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syscall/js, io/fs: fs.Read copies minimally 512 bytes to from JS to Go
2 participants