Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regexp: improve Regexp.ReplaceAll documentation and tests related to Expand part #56507

Closed
wants to merge 1 commit into from
Closed

regexp: improve Regexp.ReplaceAll documentation and tests related to Expand part #56507

wants to merge 1 commit into from

Conversation

eduardbme
Copy link
Contributor

@eduardbme eduardbme commented Nov 1, 2022 •
edited

For #40329

@eduardbme eduardbme mentioned this pull request Nov 1, 2022
Closed
@gopherbot
Copy link

This PR (HEAD: 3e09043) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/446836 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@ZekeLu
Copy link
Contributor

ZekeLu commented Nov 1, 2022

See https://github.com/golang/go/wiki/CommitMessage.

@eduardbme eduardbme changed the title regexp: improve ReplaceAllString documentation related to Expand part doc: improve re.ReplaceAllString documentation related to Expand part Nov 1, 2022
@eduardbme eduardbme force-pushed the doc-regexp-replace-all-string-expand branch from 3e09043 to 8e3ce98 Compare November 1, 2022 12:23
@gopherbot
Copy link

This PR (HEAD: 8e3ce98) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/446836 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@eduardbme eduardbme force-pushed the doc-regexp-replace-all-string-expand branch from 8e3ce98 to b844347 Compare July 26, 2023 16:55
@gopherbot
Copy link

This PR (HEAD: b844347) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/446836.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@eduardbme eduardbme changed the title doc: improve re.ReplaceAllString documentation related to Expand part regexp: improve Regexp.ReplaceAllString documentation related to Expand part Jul 26, 2023
@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@eduardbme eduardbme force-pushed the doc-regexp-replace-all-string-expand branch from b844347 to 57837ab Compare July 28, 2023 16:26
@gopherbot
Copy link

This PR (HEAD: 57837ab) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/446836.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@eduardbme eduardbme changed the title regexp: improve Regexp.ReplaceAllString documentation related to Expand part regexp: improve Regexp.ReplaceAll documentation and tests related to Expand part Jul 28, 2023
@gopherbot
Copy link

Message from Eduard Bondarenko:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Eduard Bondarenko:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@eduardbme eduardbme force-pushed the doc-regexp-replace-all-string-expand branch from 57837ab to c017d4c Compare August 1, 2023 14:45
@gopherbot
Copy link

This PR (HEAD: c017d4c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/446836.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Eduard Bondarenko:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Eduard Bondarenko:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Eduard Bondarenko:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/446836.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 7, 2023
@eduardbme @gopherbot
regexp: improve Regexp.ReplaceAll documentation and tests related to …
6ab8dfb 
…Expand part

For #40329

Change-Id: Ie0cb337545ce39cd169129227c45f7d2eaebc898
GitHub-Last-Rev: c017d4c
GitHub-Pull-Request: #56507
Reviewed-on: https://go-review.googlesource.com/c/go/+/446836
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/446836 has been merged.

@gopherbot gopherbot closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eduardbme @gopherbot @ZekeLu