Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: update name <dirinfo> field in struct file to <dirInfo> #57064

Closed
wants to merge 1 commit into from

Conversation

Ja7ad
Copy link

@Ja7ad Ja7ad commented Dec 3, 2022

In Go, the naming convention is camelCase, which is used for variables, consts, struct fields, etc..., is a private field in the file struct, so it should be changed to to be consistent with the effective Go naming convention.

…ame convention effective go

In Go, the naming convention is camelCase for unexport to other package level, which is used for variables, consts, struct fields, etc..., <dirinfo> is a private field in the file struct, so it should be changed to <dirInfo> to be consistent with the effective Go naming convention.
@Ja7ad Ja7ad changed the title os: update name <dirinfo> field in struct file to <dirInfo> base on name convention effective go os: update name <dirinfo> field in struct file to <dirInfo> Dec 3, 2022
@gopherbot
Copy link

This PR (HEAD: bb47fb1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/454995 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/454995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Javad Rajabzadeh:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/454995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/454995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/454995 has been abandoned.

Undesirable code churn.

@gopherbot gopherbot closed this Dec 4, 2022
@Ja7ad Ja7ad deleted the file branch December 4, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants