Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: update windows zsyscalls to use SyscallN #61971

Closed
wants to merge 1 commit into from

Conversation

mauri870
Copy link
Member

This is a follow up for CL 518995 that regenerates the
windows zsyscalls to use SyscallN instead of the various
SyscallX functions.

Fixes #57914

This is a follow up for CL 518995 that regenerates the
windows zsyscalls to use SyscallN instead of the various
SyscallX functions.

Fixes golang#57914
@mauri870 mauri870 changed the title syscall: update zsyscalls for windows to use SyscallN syscall: update windows zsyscalls to use SyscallN Aug 12, 2023
@gopherbot
Copy link

This PR (HEAD: 2ed3ea2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/518857.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@mauri870
Copy link
Member Author

Marking as abandoned since there is a solution where we don't need to generate the syscalls again, it only uses SyscallN for syscalls with more than 15 params.

@mauri870 mauri870 closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/sys/windows: mkwinsyscall: support syscalls with more than 15 params
2 participants