New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: revert fix request canceler leak on connection close #62233
net/http: revert fix request canceler leak on connection close #62233
Conversation
This PR (HEAD: d3cd751) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/522097. Important tips:
|
This reverts commit 291a32a due to flaking test. Updates golang#61708
d3cd751
to
3544648
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
Message from Alexander Yastrebov: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
This PR (HEAD: 3544648) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/522097. Important tips:
|
Message from Bryan Mills: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
Message from Bryan Mills: Patch Set 3: Auto-Submit+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
Message from Than McIntosh: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/522097. |
This reverts CL 515796 due to a flaking test. Updates #61708 Fixes #62224 Change-Id: I53911a07677d08c3196daaaa2708269593baf472 GitHub-Last-Rev: 3544648 GitHub-Pull-Request: #62233 Reviewed-on: https://go-review.googlesource.com/c/go/+/522097 Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
This PR is being closed because golang.org/cl/522097 has been merged. |
This reverts CL 515796 due to a flaking test. Updates golang#61708 Fixes golang#62224 Change-Id: I53911a07677d08c3196daaaa2708269593baf472 GitHub-Last-Rev: 3544648 GitHub-Pull-Request: golang#62233 Reviewed-on: https://go-review.googlesource.com/c/go/+/522097 Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
This reverts CL 515796 due to a flaking test.
Updates #61708
Fixes #62224