New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/zstd: allow zero dictionary id #63268
internal/zstd: allow zero dictionary id #63268
Conversation
This PR (HEAD: 4174519) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531515. Important tips:
|
A value of 0 has same meaning as no Dictionary_ID, in which case the frame may or may not need a dictionary to be decoded, and the ID of such a dictionary is not specified. See facebook/zstd#2172 For golang#62513
4174519
to
9cf12dc
Compare
This PR (HEAD: 9cf12dc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531515. Important tips:
|
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531515. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-09-28T02:45:50Z","revision":"7d095da5c22dcdcc2b3dca714d091a455cabb175"} Please don’t reply on this GitHub thread. Visit golang.org/cl/531515. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/531515. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/531515. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531515. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531515. |
A value of 0 has same meaning as no Dictionary_ID, in which case the frame may or may not need a dictionary to be decoded, and the ID of such a dictionary is not specified. See facebook/zstd#2172 For #62513 Change-Id: If0eafcbc5d2188576f0cb687234e30c9eb4037a6 GitHub-Last-Rev: 9cf12dc GitHub-Pull-Request: #63268 Reviewed-on: https://go-review.googlesource.com/c/go/+/531515 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Than McIntosh <thanm@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/531515 has been merged. |
A value of 0 has same meaning as no Dictionary_ID,
in which case the frame may or may not need a dictionary to be decoded,
and the ID of such a dictionary is not specified.
See facebook/zstd#2172
For #62513