New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mime/multipart: add helper to build content-disposition header contents #63324
base: master
Are you sure you want to change the base?
mime/multipart: add helper to build content-disposition header contents #63324
Conversation
This PR (HEAD: f46cc46) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
f46cc46
to
d3b4d1c
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
This PR (HEAD: d3b4d1c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 3: Run-TryBot+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Gopher Robot: Patch Set 3: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
This PR (HEAD: 722b26f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
This PR (HEAD: e312788) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
Message from Luca Maltagliati: Patch Set 5: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Ian Lance Taylor: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
This PR (HEAD: 41ee6dd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
This PR (HEAD: a52603b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
This PR (HEAD: 2a489bc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
This PR (HEAD: b35603b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
Message from Luca Maltagliati: Patch Set 8: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Ian Lance Taylor: Patch Set 9: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-10-03T19:43:22Z","revision":"783b07c8e4e1212894d04ef7f21f1be123937515"} Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Ian Lance Taylor: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Luca Maltagliati: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 9: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-06T21:41:08Z","revision":"783b07c8e4e1212894d04ef7f21f1be123937515"} Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
error: failed to run "test golang.org/x/tools module": exit status 1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Luca Maltagliati: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 9: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-09T20:54:54Z","revision":"783b07c8e4e1212894d04ef7f21f1be123937515"} Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
error: failed to run "test golang.org/x/tools module": exit status 1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
b35603b
to
7e76098
Compare
This PR (HEAD: 7e76098) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/531995. Important tips:
|
Message from Luca Maltagliati: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 10: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-10T00:54:57Z","revision":"497d84c9a5c00cd773b0e8695d8ee0b9dc27635e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Damien Neil: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Heschi Kreinick: Patch Set 10: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Carlos Amedee: Patch Set 10: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
Message from Luca Maltagliati: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/531995. |
This PR adds an helper FileContentDisposition that builds multipart
Content-Disposition header contents with field name and file name,
escaping quotes and escape characters.
The function is then called in the related helper CreateFormFile.
The new function allows users to add other custom MIMEHeaders,
without having to rewrite the char escaping logic of field name and
file name, which is provided by the new helper.
Fixes #46771