-
Notifications
You must be signed in to change notification settings - Fork 17.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/doc: fix inconsistent receiver name #64912
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
d2ed467
to
8830f5e
Compare
This PR (HEAD: 8830f5e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553335. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
8830f5e
to
9c8a594
Compare
This PR (HEAD: 9c8a594) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553335. Important tips:
|
Message from qiulaidongfeng: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
This PR (HEAD: 43e3326) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553335. Important tips:
|
Message from Mehdi Mostafavi: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from qiulaidongfeng: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
The ToText method of Package is the only one with a receiver declared 'p'; all the rest have 'pkg'.
This PR (HEAD: 7d273b4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553335. Important tips:
|
Message from Mehdi Mostafavi: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from qiulaidongfeng: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from qiulaidongfeng: Patch Set 6: -Run-TryBot Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from Rob Pike: Patch Set 6: Code-Review+2 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
Message from Dmitri Shuralyov: Patch Set 7: Auto-Submit+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
The ToText method of Package is the only one with a receiver declared 'p'; all the rest have 'pkg'. Fix it to be consistent. Change-Id: I2b47c719f4f6f8d87336316b7f80deb1b49e17dc GitHub-Last-Rev: 7d273b4 GitHub-Pull-Request: #64912 Reviewed-on: https://go-review.googlesource.com/c/go/+/553335 Run-TryBot: Rob Pike <r@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
Message from Matthew Dempsky: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/553335. |
This PR is being closed because golang.org/cl/553335 has been merged. |
The ToText method of Package is the only one with a receiver declared 'p'; all the rest have 'pkg'. Fix it to be consistent. Change-Id: I2b47c719f4f6f8d87336316b7f80deb1b49e17dc GitHub-Last-Rev: 7d273b4 GitHub-Pull-Request: golang#64912 Reviewed-on: https://go-review.googlesource.com/c/go/+/553335 Run-TryBot: Rob Pike <r@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
The ToText method of Package is the only one with a receiver declared
'p'; all the rest have 'pkg'. Fix it to be consistent.