Commits on May 28, 2024

1. cmd/go: fix -coverpkg not ignoring special directories …

   The pattern passed to `-coverpkg` when running `go test` would not
   ignore directories usually ignored by the `go` command, i.e. those
   beginning with "." or "_" are ignored by the go tool, as are directories
   named "testdata".
   
   Fix this by adding an explicit check for these (by following a similar
   check in `src/cmd/doc/dirs.go`[1]) allowing us to ignore them. The
   scope of the change is limted to package matching to only the -coverpkg
   flag of `go test` to avoid impacting -gcflags and the other per package
   flags, e.g. we don't want to change behaviour for a user building
   something that imports a leading dot package who wants to set gcflags
   for it
   
   Two tests are added for this change, one is a regression test attempting
   to directly replicate the behaviour described in the issue, the other is
   updating another test I saw fail when trialling other solutions to this
   issue so I thought it worthwhile to be explicit about the change there.
   
   See linked issue for a reproduction.
   
   Fixes golang#66038
   
   [1] https://go.googlesource.com/go/+/16e5d24480dca7ddcbdffb78a8ed5de3e5155dec/src/cmd/doc/dirs.go#136

   

   matthewhughes934 committed May 28, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f48bd17
   • Browse repository at this point

   Copy the full SHA

   f48bd17 View commit details

   Browse the repository at this point in the history