New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cgo: close the file opened in the dynimport function #66549
Conversation
This PR (HEAD: e833a32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574537. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from guoguangwu guo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-27T03:04:00Z","revision":"935297625d5896c24bb02caed09ef9cbf134c346"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-27T15:54:13Z","revision":"935297625d5896c24bb02caed09ef9cbf134c346"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
This PR (HEAD: a8af7b5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574537. Important tips:
|
Message from guoguangwu guo: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T03:03:37Z","revision":"2a8a50cf8132655ac9ef1ecc4c176141d6fa44ff"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Emmanuel Odeke: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T04:04:06Z","revision":"2a8a50cf8132655ac9ef1ecc4c176141d6fa44ff"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Emmanuel Odeke: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T15:19:52Z","revision":"2a8a50cf8132655ac9ef1ecc4c176141d6fa44ff"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T19:34:18Z","revision":"2a8a50cf8132655ac9ef1ecc4c176141d6fa44ff"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574537. |
Change-Id: Ic457e994b50a0e8c1769311937eede1e710a1293 GitHub-Last-Rev: a8af7b5 GitHub-Pull-Request: #66549 Reviewed-on: https://go-review.googlesource.com/c/go/+/574537 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Than McIntosh <thanm@google.com> Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Emmanuel Odeke <emmanuel@orijtech.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This PR is being closed because golang.org/cl/574537 has been merged. |
No description provided.