New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strings: move Clone to stringslite #67106
Conversation
This PR (HEAD: 8f1dae6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581956. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from qiulaidongfeng: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-29T10:42:11Z","revision":"4a00f27b612dee10d46f665c5b9ca1b7fe5810ea"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from qiulaidongfeng: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-29T18:15:55Z","revision":"4a00f27b612dee10d46f665c5b9ca1b7fe5810ea"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from David Chase: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
This help package like unique use Clone. Change-Id: I073125b7ba0e3b87e9cb78c3fc0b5bada78ba4cd
This PR (HEAD: 499476c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581956. Important tips:
|
Message from qiulaidongfeng: Patch Set 3: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-04T00:52:52Z","revision":"7e63da9ca3b159f41c2bb2b9038edf5b465a2998"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from qiulaidongfeng: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from qiulaidongfeng: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-04T01:07:59Z","revision":"7e63da9ca3b159f41c2bb2b9038edf5b465a2998"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581956. |
Follow-up CL help package like unique use Clone. Change-Id: Ie64adf7e1a331f47c3cfe178c368d72fc72493ff GitHub-Last-Rev: 499476c GitHub-Pull-Request: #67106 Reviewed-on: https://go-review.googlesource.com/c/go/+/581956 Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org>
This PR is being closed because golang.org/cl/581956 has been merged. |
Follow-up CL help package like unique use Clone.