Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webp: don't reject VP8X that isn't just VP8 + alpha #5

Closed
wants to merge 3 commits into from

Conversation

narrowizard
Copy link
Contributor

@narrowizard narrowizard commented Aug 20, 2020

We already support VP8 + alpha, but reject e.g. VP8 + EXIF. After this
commit, we still don't implement VP8 + EXIF (or ANIM, ICCP, etc.), but
we now silently ignore the EXIF chunk instead of rejecting it.

Fixes golang/go#25738, golang/go#38341

@gopherbot
Copy link
Contributor

This PR (HEAD: c7aa034) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/249445 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 1:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 9725bc4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/249445 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from narro wizard:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from narro wizard:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a0c2e53) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/249445 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from narro wizard:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 6: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 6: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 8: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 9:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@narrowizard narrowizard changed the title fix(webp): decode non-alpha vp8x error. webp: don't reject VP8X that isn't just VP8 + alpha Sep 20, 2020
@gopherbot
Copy link
Contributor

Message from narro wizard:

Patch Set 11:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from David Symonds:

Patch Set 11: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/249445.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 21, 2020
We already support VP8 + alpha, but reject e.g. VP8 + EXIF. After this
commit, we still don't implement VP8 + EXIF (or ANIM, ICCP, etc.), but
we now silently ignore the EXIF chunk instead of rejecting it.

Fixes golang/go#25738, golang/go#38341

Change-Id: I4e9cdb718f0768f34336eab9528b82d2c40a3ee1
GitHub-Last-Rev: a0c2e53
GitHub-Pull-Request: #5
Reviewed-on: https://go-review.googlesource.com/c/image/+/249445
Trust: David Symonds <dsymonds@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/249445 has been merged.

@gopherbot gopherbot closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants