Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

go get golint failed with golang 1.8 on Travis #421

Closed
ChTimTsubasa opened this issue Oct 23, 2018 · 1 comment
Closed

go get golint failed with golang 1.8 on Travis #421

ChTimTsubasa opened this issue Oct 23, 2018 · 1 comment

Comments

@ChTimTsubasa
Copy link

The error message is as follow:

go get golang.org/x/lint/golint
# golang.org/x/tools/go/internal/gcimporter
../../../golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias)
make: *** [setup] Error 2

Wondering if the go-lint is still supporting go 1.8?

@andybons
Copy link
Member

Go 1.8 is no longer supported by the Go team. We only support the current release and one previous. Thanks.

hamstah added a commit to hamstah/paranoidhttp that referenced this issue Dec 19, 2018
charlievieth pushed a commit to lyft/gostats that referenced this issue Jan 11, 2019
The Travis CI build was failing in master due to golint not supporting Go 1.8 any longer.

See this PR golang/lint#421
> Go 1.8 is no longer supported by the Go team. We only support the current release and one previous. Thanks.

fixes #48
xinfengliu added a commit to xinfengliu/containerd that referenced this issue Jan 6, 2020
To fix "go get -u github.com/golang/lint/golint" error.
golang/lint#421

Signed-off-by: Xinfeng Liu <xinfeng.liu@gmail.com>
xinfengliu added a commit to xinfengliu/containerd that referenced this issue Jan 7, 2020
To fix "go get -u github.com/golang/lint/golint" error.
golang/lint#421

Also fix integratinon test when using golang 1.10.x
In AddProcessToContainer(), the returned stdout buffer has x00 padded, after it is converted to string, it still has padded zeros.
This commit trims the padded zeros in string.

Replace "github.com/golang/lint/golint" with "golang.org/x/lint/golint" from below error message:
(this is needed for golang 1.12 or later)
```
package github.com/golang/lint/golint: code in directory /home/travis/gopath/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"
```

Signed-off-by: Xinfeng Liu <xinfeng.liu@gmail.com>
mojozinc pushed a commit to mojozinc/jsonui that referenced this issue Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants