Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

New import path breaks functionality #415

Closed
gerbenjacobs opened this issue Oct 11, 2018 · 11 comments · Fixed by kubernetes/kompose#1073
Closed

New import path breaks functionality #415

gerbenjacobs opened this issue Oct 11, 2018 · 11 comments · Fixed by kubernetes/kompose#1073

Comments

@gerbenjacobs
Copy link

So the changes from this commit breaks functionality for one of my projects:

package github.com/golang/lint/golint: code in directory /go/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"

Are we supposed to use the path golang.org/x/lint/golint?
@dgryski
Copy link

dgryski commented Oct 11, 2018

Yes. The official path was was updated back in February: ead987a .

This patch just enforces it.

nathan-jenan-rancher added a commit to nathan-jenan-rancher/kontainer-engine that referenced this issue Oct 11, 2018
@nathan-jenan-rancher
Updating CI to use correct golint dependency
455c7ca 
See: golang/lint#415
nathan-jenan-rancher added a commit to nathan-jenan-rancher/kontainer-engine that referenced this issue Oct 11, 2018
@nathan-jenan-rancher
Updating CI to use correct golint dependency
2b4bb58 
See: golang/lint#415
@ldez ldez mentioned this issue Oct 11, 2018
Merged
This was referenced Oct 11, 2018
Closed
Closed
nixpanic added a commit to nixpanic/external-storage that referenced this issue Oct 11, 2018
@nixpanic
tests: use "go lint" from golang.org/x/lint/golint
7d9e754 
Travis currently fails with this error:

    +go get -u github.com/golang/lint/golint
    package github.com/golang/lint/golint: code in directory /home/travis/gopath/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"

See-also: golang/lint#415
nixpanic added a commit to nixpanic/external-storage that referenced this issue Oct 11, 2018
@nixpanic
tests: use "go lint" from golang.org/x/lint/golint
b8ffeb2 
Travis currently fails with this error:

    +go get -u github.com/golang/lint/golint
    package github.com/golang/lint/golint: code in directory /home/travis/gopath/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"

It seems 'github.com/golang/lint/golint' is the old path, and now
'golang.org/x/lint/golint' should be used.

See-also: golang/lint#415
@nixpanic nixpanic mentioned this issue Oct 11, 2018
Merged
nathan-jenan-rancher added a commit to nathan-jenan-rancher/kontainer-engine that referenced this issue Oct 11, 2018
@nathan-jenan-rancher
Updating CI to use correct golint dependency
220af0f 
See: golang/lint#415
cjellick pushed a commit to rancher/kontainer-engine that referenced this issue Oct 11, 2018
@nathan-jenan-rancher
Updating CI to use correct golint dependency
fe94db3 
See: golang/lint#415
This was referenced Oct 12, 2018
Closed
Closed
This was referenced Oct 12, 2018
Closed
Closed
andybons referenced this issue Oct 12, 2018
@zchee @bradfitz
travis: add go_import_path
5906bd5 
Change-Id: I3062f23e143916f0c87ec0a043f0682b8c01612a
Reviewed-on: https://go-review.googlesource.com/c/141597
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@ldez ldez mentioned this issue Oct 13, 2018
Open
@WhiteHatTux WhiteHatTux mentioned this issue Oct 13, 2018
Closed
@gotjosh gotjosh mentioned this issue Oct 13, 2018
Closed
@aviaoh aviaoh mentioned this issue Oct 14, 2018
Merged
@hugorut hugorut mentioned this issue Oct 15, 2018
Closed
@varas varas mentioned this issue Oct 15, 2018
Merged
8 tasks
@erutherford erutherford mentioned this issue Oct 15, 2018
Merged
agrahamlincoln pushed a commit to agrahamlincoln/cortex that referenced this issue Oct 15, 2018
update golint path
e55692c 
See: golang/lint#415

Signed-off-by: Graham Rounds <graham@platform9.com>
@agrahamlincoln agrahamlincoln mentioned this issue Oct 15, 2018
Merged
@ChTimTsubasa ChTimTsubasa mentioned this issue Oct 15, 2018
Merged
6 tasks
@linyows linyows mentioned this issue Oct 16, 2018
Merged
@gilcrest gilcrest mentioned this issue Oct 16, 2018
Closed
@tao12345666333 tao12345666333 mentioned this issue Oct 16, 2018
Merged
ivan-section-io added a commit to ivan-section-io/qdisc that referenced this issue Apr 30, 2019
@ivan-section-io
Use new golint package path
446f9dd 
New path now enforced. golang/lint#415
matthewhartstonge added a commit to matthewhartstonge/gaurun-client that referenced this issue May 9, 2019
@matthewhartstonge
⚡ travis: updates golint import path.
8397251 
ref: golang/lint#415
tadaskay added a commit to mysteriumnetwork/node that referenced this issue May 20, 2019
@tadaskay
Update golint import path
74df413 
golang/lint#415
tadaskay added a commit to mysteriumnetwork/node that referenced this issue May 21, 2019
@tadaskay
Update golint import path
c6f0a0d 
golang/lint#415
@nocquidant nocquidant mentioned this issue May 23, 2019
Closed
@karlolsonuc karlolsonuc mentioned this issue May 28, 2019
Merged
@rakelkar rakelkar mentioned this issue Jun 2, 2019
Closed
@dominikh dominikh mentioned this issue Jun 15, 2019
Closed
oceyral pushed a commit to oceyral/authz that referenced this issue Jun 27, 2019
Fix golint path in Makefile
d0fb8a7 
Update as per official golang lint changes: golang/lint#415
@oceyral oceyral mentioned this issue Jun 27, 2019
Merged
liron-l pushed a commit to twistlock/authz that referenced this issue Jun 27, 2019
@oceyral
Fix golint path in Makefile (#64)
755e1ae 
Update as per official golang lint changes: golang/lint#415
@laoshaw
Copy link

laoshaw commented Jul 13, 2019

is this fixed? using 1.13beta1 and did "go get -u github.com/golang/lint/golint" and still see this

@andybons
Copy link
Member

@laoshaw that import path won’t work anymore. The correct invocation is

go get -u golang.org/x/lint/golint

philkuz added a commit to philkuz/arcanist that referenced this issue Jul 16, 2019
@philkuz
Update ArcanistGoLintLinter install instructions
840c6a3 
Old path no longer works and throws a missing package error. 
See [this issue](golang/lint#415).
@philkuz philkuz mentioned this issue Jul 16, 2019
Closed
philkuz added a commit to philkuz/arcanist that referenced this issue Jul 16, 2019
@philkuz
Update Go linter install link
4e6d567 
Go updated the path for the linter, broke the old path for linter. [This issue](golang/lint#415) confirms the change.
@philkuz philkuz mentioned this issue Jul 16, 2019
Closed
@AlexSkrypnyk AlexSkrypnyk mentioned this issue Jul 17, 2019
Closed
marksliva pushed a commit to marksliva/gpupgrade that referenced this issue Sep 5, 2019
Fix make depend-dev
c4ad732 
Update the lint dependency to one that works.
golang/lint#415
@zippolyte zippolyte mentioned this issue Sep 13, 2019
Merged
ankon added a commit to Collaborne/ingress that referenced this issue Nov 19, 2019
@ankon
Update Go to 1.12
751d167 
While there: Update the golint reference to 'golang.org/x/lint/golint' as per golang/lint#415.
@soraxas soraxas mentioned this issue Jan 23, 2020
Merged
petemoore added a commit to taskcluster/taskcluster that referenced this issue Feb 6, 2020
@petemoore
fix for golang/lint#415
685e992
mojozinc pushed a commit to mojozinc/jsonui that referenced this issue Feb 18, 2020
@sjangrativo
update golint path in Makefile
2f6f674 
refer: golang/lint#415
mojozinc pushed a commit to mojozinc/jsonui that referenced this issue Feb 18, 2020
@sjangrativo
update Makefile and travis yaml
4f25281 
1.8 not supported : golang/lint#421
golint refer: golang/lint#415
ablarry pushed a commit to ablarry/golang-codebuild-aws that referenced this issue Aug 5, 2020
Update reference to get lint . ref golang/lint#415
33bb0f9
@drs-11 drs-11 mentioned this issue Oct 3, 2020
Closed
juamedgod pushed a commit to juamedgod/bcrypt-cli that referenced this issue Mar 25, 2021
@aruiz14
New import path for golint (#5)
c480d77 
Ref: golang/lint#415

Also upgrade Go version in Dockerfile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Go versions HaraldNordgren/kompose
5 participants
@andybons @gerbenjacobs @dgryski @ddewar2k @laoshaw