Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google: support scopes for JWT access token #504

Closed
wants to merge 3 commits into from
Closed

google: support scopes for JWT access token #504

wants to merge 3 commits into from

Conversation

shinfan
Copy link
Contributor

@shinfan shinfan commented Jun 15, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jun 15, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: ff3df73) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/327929 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/327929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a4ca194) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/327929 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Shin Fan:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/327929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 2: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/327929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/327929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/327929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: efb2e8a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/327929 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Shin Fan:

Patch Set 3: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/327929.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 15, 2021
@shinfan
google: support scopes for JWT access token
d040287 
Change-Id: I11acd87a56cd003fdb68a5a687e37df450c400d1
GitHub-Last-Rev: efb2e8a
GitHub-Pull-Request: #504
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/327929
Trust: Shin Fan <shinfan@google.com>
Trust: Cody Oss <codyoss@google.com>
Run-TryBot: Shin Fan <shinfan@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cody Oss <codyoss@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/327929 has been merged.

@gopherbot gopherbot closed this Jun 15, 2021
@shinfan shinfan mentioned this pull request Jun 22, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/gapic-generator-go that referenced this pull request Jun 23, 2021
@shinfan
gapic: support EnableJwtWithScope for gRPC GAPIC clients (#674)
f6bebb1 
- Update the GAPIC clients to allow scope for self-signed JWT
- The self-signed JWT is now the default authentication method for service account instead of OAuth 2.0
- Self-signed JWT AIP: https://google.aip.dev/auth/4111
- Related PRs:
  -  googleapis/google-api-go-client#1075
  -  golang/oauth2#504
  - aip-dev/google.aip.dev#764
codegod2222 added a commit to codegod2222/oauth_go that referenced this pull request Nov 25, 2022
@codegod2222
google: support scopes for JWT access token
c59e79c 
Change-Id: I11acd87a56cd003fdb68a5a687e37df450c400d1
GitHub-Last-Rev: efb2e8a08a8db0dc654298b90b814b3b7cb4d83d
GitHub-Pull-Request: golang/oauth2#504
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/327929
Trust: Shin Fan <shinfan@google.com>
Trust: Cody Oss <codyoss@google.com>
Run-TryBot: Shin Fan <shinfan@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cody Oss <codyoss@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinfan @gopherbot