internal/postgres: update UpsertSearchDocument to prefer non-incompat…

…ible modules

Updates UpsertSearchDocument's to use orderByLatest in the query to
prefer compatible modules when inserting into the search_documents
table. This change updates the versions seen in the search results once
the module is reprocessed.

before: https://i.imgur.com/A7boYiC.png
after: https://i.imgur.com/ZLdTuex.png

Updates golang/go#37714

Change-Id: I527e6f157c5ddfe2a73e561f0be78738d97bb2fc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/249278
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>

internal/postgres/search.go

@@ -530,13 +530,7 @@ var upsertSearchStatement = fmt.Sprintf(`
 		AND p.version = m.version
 	WHERE
 		p.path = $1
-	ORDER BY
-		-- Order the versions by release then prerelease.
-		-- The default version should be the first release
-		-- version available, if one exists.
-		m.version_type = 'release' DESC,
-		m.sort_version DESC,
-		m.module_path DESC
+	%s
 	LIMIT 1
 	ON CONFLICT (package_path)
 	DO UPDATE SET
@@ -556,7 +550,7 @@ var upsertSearchStatement = fmt.Sprintf(`
 			THEN search_documents.version_updated_at
 			ELSE CURRENT_TIMESTAMP
 			END)
-	;`, hllRegisterCount)
+	;`, hllRegisterCount, orderByLatest)
 
 // UpsertSearchDocuments adds search information for mod ot the search_documents table.
 func UpsertSearchDocuments(ctx context.Context, db *database.DB, mod *internal.Module) (err error) {

internal/postgres/search_test.go

@@ -731,6 +731,11 @@ func TestUpsertSearchDocument(t *testing.T) {
 	}
 
 	insertModule("v1.0.0", false)
+
+	// Ensures the row updated in the search_document table for a given module
+	// is updated with a version that prefers non-incompatible modules. (The
+	// latest version after this insertion should remain v1.0.0)
+	insertModule("v2.0.0+incompatible", false)
 	sdOriginal := getSearchDocument()
 
 	insertModule("v0.5.0", true)