Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: latest version should not be +incompatible #37714

Open
jba opened this issue Mar 6, 2020 · 3 comments
Open

x/pkgsite: latest version should not be +incompatible #37714

jba opened this issue Mar 6, 2020 · 3 comments

Comments

@jba
Copy link
Contributor

@jba jba commented Mar 6, 2020

When deciding which version of a module is the latest, if there is a version with a go.mod file, prefer it to incompatible versions.

Example: given versions

  • v2.0.0+incompatible
  • v1.2.3
    we would display the first as latest. We should display the second.
@jba jba added the pkgsite label Mar 6, 2020
@jba jba self-assigned this Mar 6, 2020
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2020
@jba
Copy link
Contributor Author

@jba jba commented Mar 6, 2020

The go command behaves similarly as of 1.14: https://golang.org/doc/go1.14#incompatible-versions.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Mar 10, 2020

/cc @fflewddur for context

@julieqiu julieqiu added the UX label Mar 10, 2020
@julieqiu julieqiu changed the title go.dev: latest version should not be +incompatible x/pkgsite: latest version should not be +incompatible Jun 15, 2020
@zot
Copy link

@zot zot commented Jul 12, 2020

Nice! Looks like this would resolve the long-standing issue with libp2p docs: libp2p/go-libp2p#805

@jamalc jamalc assigned jamalc and unassigned jba Jul 27, 2020
@julieqiu julieqiu assigned AceroM and unassigned jamalc Jul 31, 2020
@julieqiu julieqiu removed the UX label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.