Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links #6

Closed
wants to merge 1 commit into from
Closed

x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links #6

wants to merge 1 commit into from

Conversation

nickel8448
Copy link
Contributor

@nickel8448 nickel8448 commented Aug 28, 2020 •
edited
Loading

x/pkgsite: trim HTTP or HTTPS Scheme from source code links

A new template function is created, which trims the scheme of the URL.
Tests in server_test.go are modified accordingly.

Fixes golang/go#40943

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 28, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 6177bf8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/251277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@nickel8448
Copy link
Contributor Author

This is not passing all the errors when I run ./all.bash. The failing test -

--- FAIL: TestFetchOverviewDetails (0.07s)
    overview_test.go:57: constructOverviewDetails("github.com/valid/module_name/foo", "v1.0.0") mismatch (-want +got):
          &frontend.OverviewDetails{
          	... // 4 identical fields
          	ReadMeSource:    "github.com/valid/module_name@v1.0.0/README.md",
          	Redistributable: true,
        - 	RepositoryURL:   "github.com/valid/module_name",
        + 	RepositoryURL:   "https://github.com/valid/module_name",
          }

Can someone guide me how can I amend the code to accommodate this?

Thanks

@gopherbot
Copy link
Contributor

Message from Thanabodee Charoenpiriyakij:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Thanabodee Charoenpiriyakij:

Patch Set 1: Code-Review-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/47798c08-cd52-449c-98bd-256543da42c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/47798c08-cd52-449c-98bd-256543da42c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links
7310642 
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
@gopherbot
Copy link
Contributor

This PR (HEAD: 7310642) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/251277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/46b66fa4-aed0-4702-935f-3e47cb3357f8

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 2: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/46b66fa4-aed0-4702-935f-3e47cb3357f8

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rahul Wadhwani:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rahul Wadhwani:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Julie Qiu:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rahul Wadhwani:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/251277.
After addressing review feedback, remember to publish your drafts!

@nickel8448 nickel8448 closed this Oct 4, 2020
@nickel8448 nickel8448 deleted the trim-https-template branch October 4, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
3 participants
@nickel8448 @gopherbot @googlebot