Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: trim https:// from source links #40943

Open
julieqiu opened this issue Aug 21, 2020 · 9 comments · May be fixed by golang/pkgsite#6
Open

x/pkgsite: trim https:// from source links #40943

julieqiu opened this issue Aug 21, 2020 · 9 comments · May be fixed by golang/pkgsite#6

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 21, 2020

Source code links on the overview tab currently show "https://". We should be trim the https:// when displaying the link:

Example - for https://pkg.go.dev/golang.org/x/pkgsite@v0.0.0-20200820201329-47151e4cbeb8/cmd/frontend?tab=overview, we currently show:

image

Instead, we should show:

image

@tooolbox
Copy link

@tooolbox tooolbox commented Aug 21, 2020

@julieqiu I was wandering past and noticed that you have a few issues with help wanted on them. Is this literally something that a community member could hit, or are you more using the labels for internal-in-the-open use?

Either one is great, just pure curiosity.

@tooolbox
Copy link

@tooolbox tooolbox commented Aug 21, 2020

Sorry, I just saw this: https://github.com/golang/pkgsite/blob/master/CONTRIBUTING.md#finding-issues

In particular, we would love your help on issues tagged with the help wanted label.

👍

@wingyplus
Copy link
Contributor

@wingyplus wingyplus commented Aug 22, 2020

I think we need to add template function for strip http scheme. What do you think?

@rahulw
Copy link

@rahulw rahulw commented Aug 22, 2020

Hey @wingyplus and @julieqiu if it is ok, can I take this issue?

@tooolbox
Copy link

@tooolbox tooolbox commented Aug 22, 2020

Before you begin working on an issue, please leave a comment that you are claiming it.

I think you can just claim it and do it, I don't think you need to get an acceptance, although I could be wrong.

EDIT: Sorry, might be good to coordinate with @wingyplus since he has talked about it already, I more meant that if the issue is created and says help wanted we probably don't need to check with @julieqiu each time because otherwise she'll turn into a full-time dev manager 😉

@rahulw
Copy link

@rahulw rahulw commented Aug 22, 2020

Before you begin working on an issue, please leave a comment that you are claiming it.

I think you can just claim it and do it, I don't think you need to get an acceptance, although I could be wrong.

EDIT: Sorry, might be good to coordinate with @wingyplus since he has talked about it already, I more meant that if the issue is created and says help wanted we probably don't need to check with @julieqiu each time because otherwise she'll turn into a full-time dev manager 😉

Hey @tooolbox, thanks for your comment. What you are saying makes complete sense.

I will coordinate with @wingyplus to check who can contribute to this. I am fairly new to this hence learning the ropes.

@wingyplus please let me know if you are already working on this or not.

@wingyplus
Copy link
Contributor

@wingyplus wingyplus commented Aug 23, 2020

@rahulw i didn't start working on this. So you can take this one.

rahulw added a commit to rahulw/pkgsite that referenced this issue Aug 23, 2020
Trimming the URL by adding a new function to overview.go which trims the
URL

Fixes golang/go#40943
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 23, 2020

Change https://golang.org/cl/250040 mentions this issue: x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

rahulw added a commit to rahulw/pkgsite that referenced this issue Aug 27, 2020
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
rahulw added a commit to rahulw/pkgsite that referenced this issue Aug 27, 2020
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
rahulw added a commit to rahulw/pkgsite that referenced this issue Aug 28, 2020
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 28, 2020

Change https://golang.org/cl/251277 mentions this issue: x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links

rahulw added a commit to rahulw/pkgsite that referenced this issue Sep 2, 2020
Trimming the URL by creating a new template function which trims the
scheme of the URL

Fixes golang/go#40943
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.