Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: use /proc/self/exe instead of os.Args[0] in test. #8

Closed
wants to merge 1 commit into from

Conversation

hugelgupf
Copy link
Contributor

If these tests happen to be run out of order, TestGetwd can be run before TestPassFD. TestGetwd changes the cwd, so os.Args[0] is potentially not relative to the right directory anymore.

(cc: googlers, this is so I can import a new version of x/sys/unix to g3.)

If these tests happen to be run out of order, TestGetwd can be run before TestPassFD. TestGetwd changes the cwd, so os.Args[0] is potentially not relative to the right directory anymore.
@gopherbot
Copy link

This PR (HEAD: c119088) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/sys/+/103858 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Christopher Koch:

Patch Set 1:

(this is me, it was just easier to use the GitHub web ui to open this change.)


Please don’t reply on this GitHub thread. Visit golang.org/cl/103858.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

Seems like this will fail on all Unix without proc self exe.


Please don’t reply on this GitHub thread. Visit golang.org/cl/103858.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Elias Naur:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/103858.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/103858.
After addressing review feedback, remember to publish your drafts!

@hugelgupf hugelgupf closed this Apr 4, 2018
@gopherbot
Copy link

Message from Christopher Koch:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/103858.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants