-
Notifications
You must be signed in to change notification settings - Fork 728
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src/goToolsInformation: fix go-outline version
There is no v1.0.0 version. The tagging of go-outline project doesn't follow go modules versioning convention, so the release tag version is not recognized. Since we pinned the 3rd party tools versions after https://go-review.googlesource.com/c/vscode-go/+/435375 we also need to adjust the code path that pick the version of tools whose latest versions require go 1.18+ to build. Use Tool.defaultVersion only if we are handling these special cases. (gofumpt, golangci-lint, staticcheck) Also, set GOMODCACHE explicitly when interacting with the fake local proxy. When the test runs in an environment with GOMODCACHE is set, the test ends up polluting the specified GOMODCACHE with fake data from the local test proxy. Our intention was to use GOPATH[0]/pkg/mod as module cache during the test. Fixes #2485 Updates #1850 Change-Id: Iad6cb662f637d444b9a8047db2aa166965144db8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/442786 Reviewed-by: Jamal Carvalho <jamal@golang.org> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
- Loading branch information
Showing
5 changed files
with
50 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters