Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: pin gofumpt and golangci-lint versions, or exclude them from autoinstallation if go version is not recent #2485

Closed
hyangah opened this issue Sep 29, 2022 · 4 comments
Closed

tools: pin gofumpt and golangci-lint versions, or exclude them from autoinstallation if go version is not recent #2485

hyangah opened this issue Sep 29, 2022 · 4 comments
Assignees
@hyangah
Labels
chore/testing issues related to bugs in test, CI setup FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
v0.36.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 29, 2022

They don't build with go1.16, go1.17 any more.
Our go1.16, 1.17 test workflows are broken.
@hyangah hyangah added chore/testing issues related to bugs in test, CI setup NeedsFix The path to resolution is known, but the work has not been done. labels Sep 29, 2022
@gopherbot gopherbot added this to the Untriaged milestone Sep 29, 2022
@hyangah hyangah modified the milestones: Untriaged, v0.36.0 Sep 29, 2022
@hyangah hyangah self-assigned this Sep 29, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/441878 mentions this issue: src/goTools: specify gofumpt/golangci-lint versions for old go

@hyangah
Copy link
Contributor Author

hyangah commented Oct 13, 2022

This is broken because we now set the default version for all 3party tools.

https://github.com/golang/vscode-go/blob/master/src/goInstallTools.ts#L262 sets the default version and making decision in getImportPathWithVersion is too late. reopening.

@hyangah hyangah reopened this Oct 13, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/442786 mentions this issue: rc/goToolsInformation: fix go-outline version

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/501200 mentions this issue: src/goToolsInformation.ts: update gopls version and unpin golangci-lint

gopherbot pushed a commit that referenced this issue Jun 6, 2023
@hyangah
src/goToolsInformation.ts: update gopls version and unpin golangci-lint
df36d6f 
golangci-lint is frequently released (more frequently than vscode-go).
The community and maintainers group of golangci-lint are sufficiently
large, so we expect breakages/security issues involving the tool to be
reasonably monitored and handled. Like the alternative linter
`staticcheck`, exclude `golangci-lint` from the pinned tools list.

Updates #2763
Updates #2485

Change-Id: If4d74a56a1da8f58575ab26c0325be8a1f3906a1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501200
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
chore/testing issues related to bugs in test, CI setup FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
v0.36.0
Development

No branches or pull requests
2 participants
@hyangah @gopherbot