-
Notifications
You must be signed in to change notification settings - Fork 729
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src/goLanguageServer: improve automated gopls log collection
Now we report the log collection failure reason when we fail to capture and sanitize gopls log automatically. And, we configure the lsp client to show the output channel in case of error events, and also try to read the trace output three times just in case the output window wasn't able to be shown yet. The choice of all the constants here (trying 3 times, sleeping, 10 or 20 ms sleep) is all arbitrary. Can work or not. Testing is hard. The report includes the extension version and the editor name info to help us checking whether users are using the latest extension version and the usual editor application. For #984 Change-Id: I6e307314e0556520b76a8e444e6b0f861575efd2 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/274449 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Peter Weinberger <pjw@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
- Loading branch information
Showing
2 changed files
with
65 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters