Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls: investigate why we still see many empty gopls automated issue reports #984

Closed
hyangah opened this issue Dec 1, 2020 · 3 comments
Closed

gopls: investigate why we still see many empty gopls automated issue reports #984

hyangah opened this issue Dec 1, 2020 · 3 comments
Milestone
v0.40.1

Comments

@hyangah
Copy link
Contributor

hyangah commented Dec 1, 2020

My guess is a race condition - gopls trace output window should be shown before the automated issue report logic can read and process the output. But there could be other issues such as unexpected output formats. Investigate and improve the robustness.
@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 1, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/274449 mentions this issue: src/goLanguageServer: improve automated gopls log collection

gopherbot pushed a commit that referenced this issue Dec 4, 2020
@hyangah
src/goLanguageServer: improve automated gopls log collection
4fee2d6 
Now we report the log collection failure reason when we fail to
capture and sanitize gopls log automatically.
And, we configure the lsp client to show the output channel in
case of error events, and also try to read the trace output
three times just in case the output window wasn't able to be
shown yet. The choice of all the constants here (trying 3 times,
sleeping, 10 or 20 ms sleep) is all arbitrary. Can work or not.
Testing is hard.

The report includes the extension version and the editor name info
to help us checking whether users are using the latest extension
version and the usual editor application.

For #984

Change-Id: I6e307314e0556520b76a8e444e6b0f861575efd2
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/274449
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/276553 mentions this issue: [release] src/goLanguageServer: improve automated gopls log collection

@hyangah hyangah added the automatedReport Automatically created issues label Mar 13, 2021
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre stamblerre modified the milestones: Untriaged, Backlog Apr 9, 2021
@hyangah hyangah removed the automatedReport Automatically created issues label Jun 14, 2022
@hyangah hyangah modified the milestones: vscode-go/unplanned, v0.38.0 Jan 5, 2023
@suzmue suzmue modified the milestones: v0.38.0, v0.39.0 Feb 22, 2023
@hyangah hyangah modified the milestones: v0.39.0, v0.40.0 Jun 8, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/539415 mentions this issue: src/language/goLanguageServer: improve suggestGoplsIssueReport

@hyangah hyangah removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 6, 2023
@hyangah hyangah modified the milestones: v0.40.0, v0.41.0, v0.40.1 Nov 6, 2023
@hyangah hyangah modified the milestones: v0.40.1, v0.41.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.40.1
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @suzmue @gopherbot