Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: respect configured build tags/flags #128

Open
ramya-rao-a opened this issue May 28, 2020 · 4 comments
Open

debug: respect configured build tags/flags #128

ramya-rao-a opened this issue May 28, 2020 · 4 comments
Labels
debug/config Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test Debug Issues related to the debugging functionality of the extension.
Projects
Debug
Milestone
vscode-go/unplanned

Comments

@ramya-rao-a
Copy link
Contributor

Currently, build flags and build tags from settings are ignored when debugging. It is expected one update the buildFlags property in the debug configuration in order to provide build flags or tags. History on why this came to be so can be found microsoft/vscode-go#3185 (comment).

As explained in the link above, there is scope for improvement here by having the debugger respect the build flags and build tags settings
@ramya-rao-a ramya-rao-a mentioned this issue May 28, 2020
Closed
@stamblerre stamblerre added the Debug Issues related to the debugging functionality of the extension. label May 29, 2020
@stamblerre stamblerre changed the title Use buildTags from settings when debugging debug: respect configured build tags/flags Jun 3, 2020
@hyangah
Copy link
Contributor

hyangah commented Jun 3, 2020

There is a similar issue related to gopls (#155) - except that gopls will need more flags and editor-related settings to be propagated.

@hyangah hyangah added this to Needs triage in Debug Sep 17, 2020
@hyangah hyangah moved this from Needs triage to Low priority in Debug Oct 26, 2020
@hyangah
Copy link
Contributor

hyangah commented Oct 26, 2020

This should apply to both delve dap and old debug adapter.
/cc @suzmue because she's looking into another issue that involves selective gcflags and GOOS/GOARCH plumbing.

This was referenced Nov 30, 2020
Open
Open
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@hyangah hyangah modified the milestones: Untriaged, Backlog Apr 14, 2021
robberphex added a commit to robberphex/vscode-go that referenced this issue Sep 21, 2021
@robberphex
debug: do not remove gcflags
d495a1a 
Updates golang#128
@robberphex
Copy link

robberphex commented Sep 21, 2021 •
edited
Loading

Go v1.17 support multi -gcflags. Does that mean we don't have to remove gcflags?

#1790

@StrongChenYu
Copy link

Is there any other solution for this problem? Thank you in advance.

@suzmue suzmue removed their assignment Nov 5, 2021
@hyangah hyangah mentioned this issue Mar 30, 2022
Closed
@polinasok polinasok added the debug/config Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test label Mar 30, 2022
@k-jingyang k-jingyang mentioned this issue Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debug/config Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test Debug Issues related to the debugging functionality of the extension.
Projects
No open projects
Debug
  
Low priority
Milestone
vscode-go/unplanned
Development

No branches or pull requests
8 participants
@robberphex @hyangah @stamblerre @suzmue @gopherbot @ramya-rao-a @StrongChenYu @polinasok