Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls: add documentation and warnings about ignored settings #155

Closed
stamblerre opened this issue Jun 3, 2020 · 3 comments
Closed

gopls: add documentation and warnings about ignored settings #155

stamblerre opened this issue Jun 3, 2020 · 3 comments
Labels
Documentation FrozenDueToAge
Projects
vscode-go: gopls by default
Milestone
v0.20.0

Comments

@stamblerre
Copy link
Contributor

See the original discussion at microsoft/vscode-go#2965.

A number of VS Code Go settings, including "go.buildTags" are ignored when used with gopls. We should either propagate these settings or offer a warning that they are being ignored.
@stamblerre stamblerre mentioned this issue Jun 3, 2020
Closed
@hyangah hyangah mentioned this issue Jun 3, 2020
Open
@hyangah hyangah added this to the Gopls by default milestone Aug 21, 2020
@stamblerre stamblerre moved this from Critical to Documentation in vscode-go: gopls by default Nov 10, 2020
@hyangah hyangah modified the milestones: Gopls by default, v0.20.0 Nov 20, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/273146 mentions this issue: src/goLanguageServer: propagate go.buildFlags,buildTags to gopls

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/273147 mentions this issue: package.json: mark settings that are not applicable when using gopls

gopherbot pushed a commit that referenced this issue Dec 3, 2020
@hyangah
package.json: mark settings that are not applicable when using gopls
49bca83 
For #155

Change-Id: I4efca525ea83c19ec4ed1a0949d76d104f3fd701
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273147
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah hyangah modified the milestones: v0.21.0, v0.20.0 Dec 16, 2020
gopherbot pushed a commit that referenced this issue Dec 21, 2020
@hyangah
src/goLanguageServer: propagate go.buildFlags,buildTags to gopls
f38e348 
They are passed as gopls.buildFlags only if gopls.buildFlags isn't
already explicitly set - users have to use JSON-based UI and add
the fields (including []).

If go.buildFlags has -tags, go.buildTags is ignored, which is
consistent with the extension's build behavior coded in goBuild
(goBuild.ts).

For #155

Change-Id: I03d5f5eb58d049454fb4a66d902a7daea4a1269f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273146
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@golang golang deleted a comment from gopherbot Dec 21, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/279419 mentions this issue: docs/gopls.md: update documentation about gopls block

vscode-go: gopls by default automation moved this from Documentation to Done Dec 22, 2020
@golang golang locked and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
No open projects
vscode-go: gopls by default
  
Done
Milestone
v0.20.0
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot