src/goTest: Add command Test Function At Cursor or Test Previous #1509

mislav · 2021-05-18T10:20:43Z

This runs Test Function At Cursor if a unit test is found at the
cursor, otherwise it turns Test Previous.

google-cla · 2021-05-18T10:20:50Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

mislav · 2021-05-18T10:22:01Z

@googlebot I signed it!

gopherbot · 2021-05-18T10:41:40Z

This PR (HEAD: c97b2eb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/320769 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-18T10:46:10Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-18T20:01:32Z

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-18T20:12:51Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/28bedfb6-9e18-47d4-a375-b5341c64ee2b

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-18T20:14:58Z

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/28bedfb6-9e18-47d4-a375-b5341c64ee2b

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-18T20:40:34Z

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-19T12:04:13Z

This PR (HEAD: 0e3f90f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/320769 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-19T12:15:39Z

Message from Mislav Marohnić:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-19T12:17:54Z

Message from Mislav Marohnić:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-25T14:06:27Z

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-25T14:13:23Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/268215b1-3e0a-40d3-8900-ab2ca0dc91b0

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-25T14:20:15Z

Message from kokoro:

Patch Set 2: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/268215b1-3e0a-40d3-8900-ab2ca0dc91b0

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

This runs `Test Function At Cursor` if a unit test is found at the cursor, otherwise it turns `Test Previous`.

gopherbot · 2021-05-25T14:43:36Z

This PR (HEAD: 0054155) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/320769 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-25T14:45:54Z

Message from Mislav Marohnić:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-26T23:37:33Z

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-26T23:41:53Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/83386db7-94a9-40ab-879a-b68b4d7aea66

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-26T23:48:14Z

Message from kokoro:

Patch Set 3: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/83386db7-94a9-40ab-879a-b68b4d7aea66

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-27T12:58:54Z

Message from Hyang-Ah Hana Kim:

Patch Set 3: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-27T13:58:33Z

Message from Mislav Marohnić:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-05-27T15:55:35Z

Message from Michael Knyszek:

Patch Set 4: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/320769.
After addressing review feedback, remember to publish your drafts!

This runs `Test Function At Cursor` if a unit test is found at the cursor, otherwise it turns `Test Previous`. Fixes #1508 Change-Id: I91305797dfeccd79c1f5ea14298a60803f24492b GitHub-Last-Rev: 0054155 GitHub-Pull-Request: #1509 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/320769 Trust: Michael Knyszek <mknyszek@google.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

gopherbot · 2021-05-27T20:08:29Z

This PR is being closed because golang.org/cl/320769 has been merged.

hyangah · 2021-06-15T18:08:37Z

We will soon release this in v0.26.0.
@mislav It would be great if you can take a look and test that your change is still working correctly.
https://github.com/golang/vscode-go/releases/tag/v0.26.0-rc.1
Thanks.

In the case of cursorOrPrevious command not finding a Go test under the cursor, it will call go.test.previous. However, cursorOrPrevious automatically saves when there was a test found, but previous does not. This can lead to the user being surprised as to why doesn't cursorOrPrevious always save. Followup to #1509 Change-Id: Ia5b625b4819727555fb20a1fb022200a2e4abd4e GitHub-Last-Rev: 1ec414f GitHub-Pull-Request: #1751 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/347789 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>

google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label May 18, 2021

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels May 18, 2021

mislav force-pushed the test-cursor-or-previous branch from c97b2eb to 0e3f90f Compare May 19, 2021 12:04

mislav added 2 commits May 25, 2021 16:41

src/goTest: enable handling the "not found" case in testAtCursor

2b1cf62

src/goTest: Add command Test Function At Cursor or Test Previous

0054155

This runs `Test Function At Cursor` if a unit test is found at the cursor, otherwise it turns `Test Previous`.

mislav force-pushed the test-cursor-or-previous branch from 0e3f90f to 0054155 Compare May 25, 2021 14:42

hyangah added this to the v0.26.0 milestone May 27, 2021

hyangah changed the title ~~Add a command to run the test at cursor or re-run previous test~~ src/goTest: Add command Test Function At Cursor or Test Previous May 27, 2021

gopherbot closed this May 27, 2021

mislav mentioned this pull request Sep 4, 2021

src/goTest: ensure that cursorOrPrevious always saves #1751

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src/goTest: Add command Test Function At Cursor or Test Previous #1509

src/goTest: Add command Test Function At Cursor or Test Previous #1509

mislav commented May 18, 2021 •

edited by hyangah

google-cla bot commented May 18, 2021

mislav commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 19, 2021

gopherbot commented May 19, 2021

gopherbot commented May 19, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 26, 2021

gopherbot commented May 26, 2021

gopherbot commented May 26, 2021

gopherbot commented May 27, 2021

gopherbot commented May 27, 2021

gopherbot commented May 27, 2021

gopherbot commented May 27, 2021

hyangah commented Jun 15, 2021

src/goTest: Add command Test Function At Cursor or Test Previous #1509

src/goTest: Add command Test Function At Cursor or Test Previous #1509

Conversation

mislav commented May 18, 2021 • edited by hyangah

google-cla bot commented May 18, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

mislav commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 18, 2021

gopherbot commented May 19, 2021

gopherbot commented May 19, 2021

gopherbot commented May 19, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 25, 2021

gopherbot commented May 26, 2021

gopherbot commented May 26, 2021

gopherbot commented May 26, 2021

gopherbot commented May 27, 2021

gopherbot commented May 27, 2021

gopherbot commented May 27, 2021

gopherbot commented May 27, 2021

hyangah commented Jun 15, 2021

mislav commented May 18, 2021 •

edited by hyangah