Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/goTest: ensure that cursorOrPrevious always saves #1751

Closed
wants to merge 1 commit into from

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Sep 4, 2021

In the case of cursorOrPrevious command not finding a Go test under the
cursor, it will call go.test.previous. However, cursorOrPrevious
automatically saves when there was a test found, but previous does not.
This can lead to the user being surprised as to why doesn't
cursorOrPrevious always save.

Followup to #1509

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 4, 2021
@gopherbot
Copy link
Collaborator

This PR (HEAD: 2cfece2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/347789 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Mislav Marohnić:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/bda8dd19-97aa-4543-86d4-a66b52967fa1


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/bda8dd19-97aa-4543-86d4-a66b52967fa1


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Mislav Marohnić:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

In the case of `go.test.cursorOrPrevious` command not finding a Go test
under the cursor, it will call `go.test.previous`. However,
`cursorOrPrevious` automatically saves when there was a test found, but
`previous` does not. This can lead to the user being surprised as to why
doesn't `cursorOrPrevious` always save.
@mislav mislav force-pushed the cursor-or-previous-ensure-save branch from 2cfece2 to 1ec414f Compare September 22, 2021 16:21
@gopherbot
Copy link
Collaborator

This PR (HEAD: 1ec414f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/347789 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Mislav Marohnić:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1 Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/dbc564cc-7758-4985-bf00-50183c73a5cc


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/dbc564cc-7758-4985-bf00-50183c73a5cc


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/73b19011-e5f2-4eb2-bd86-02885d259d1a


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/73b19011-e5f2-4eb2-bd86-02885d259d1a


Please don’t reply on this GitHub thread. Visit golang.org/cl/347789.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 22, 2021
In the case of cursorOrPrevious command not finding a Go test under the
cursor, it will call go.test.previous. However, cursorOrPrevious
automatically saves when there was a test found, but previous does not.
This can lead to the user being surprised as to why doesn't
cursorOrPrevious always save.

Followup to #1509

Change-Id: Ia5b625b4819727555fb20a1fb022200a2e4abd4e
GitHub-Last-Rev: 1ec414f
GitHub-Pull-Request: #1751
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/347789
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/347789 has been merged.

@gopherbot gopherbot closed this Sep 22, 2021
@mislav mislav deleted the cursor-or-previous-ensure-save branch October 29, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants