-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/goTest: ensure that cursorOrPrevious always saves #1751
Conversation
This PR (HEAD: 2cfece2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/347789 to see it. Tip: You can toggle comments from me using the |
Message from Hyang-Ah Hana Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from Mislav Marohnić: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from Hyang-Ah Hana Kim: Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from kokoro: Patch Set 1: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from kokoro: Patch Set 1: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from Mislav Marohnić: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from Hyang-Ah Hana Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
In the case of `go.test.cursorOrPrevious` command not finding a Go test under the cursor, it will call `go.test.previous`. However, `cursorOrPrevious` automatically saves when there was a test found, but `previous` does not. This can lead to the user being surprised as to why doesn't `cursorOrPrevious` always save.
2cfece2
to
1ec414f
Compare
This PR (HEAD: 1ec414f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/347789 to see it. Tip: You can toggle comments from me using the |
Message from Mislav Marohnić: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from Hyang-Ah Hana Kim: Patch Set 2: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from kokoro: Patch Set 2: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from kokoro: Patch Set 2: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from kokoro: Patch Set 2: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
Message from kokoro: Patch Set 2: TryBot-Result+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/347789. |
In the case of cursorOrPrevious command not finding a Go test under the cursor, it will call go.test.previous. However, cursorOrPrevious automatically saves when there was a test found, but previous does not. This can lead to the user being surprised as to why doesn't cursorOrPrevious always save. Followup to #1509 Change-Id: Ia5b625b4819727555fb20a1fb022200a2e4abd4e GitHub-Last-Rev: 1ec414f GitHub-Pull-Request: #1751 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/347789 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
This PR is being closed because golang.org/cl/347789 has been merged. |
In the case of cursorOrPrevious command not finding a Go test under the
cursor, it will call go.test.previous. However, cursorOrPrevious
automatically saves when there was a test found, but previous does not.
This can lead to the user being surprised as to why doesn't
cursorOrPrevious always save.
Followup to #1509