fix: keep only typecheck issues (#4640)

golangci · Apr 14, 2024 · 44c070a · 44c070a
1 parent 40d4872
commit 44c070a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/pkg/result/processors/invalid_issue.go b/pkg/result/processors/invalid_issue.go
@@ -22,16 +22,20 @@ func (InvalidIssue) Name() string {
 }
 
 func (p InvalidIssue) Process(issues []result.Issue) ([]result.Issue, error) {
+	tcIssues := filterIssues(issues, func(issue *result.Issue) bool {
+		return issue.FromLinter == "typecheck"
+	})
+
+	if len(tcIssues) > 0 {
+		return tcIssues, nil
+	}
+
 	return filterIssuesErr(issues, p.shouldPassIssue)
 }
 
 func (InvalidIssue) Finish() {}
 
 func (p InvalidIssue) shouldPassIssue(issue *result.Issue) (bool, error) {
-	if issue.FromLinter == "typecheck" {
-		return true, nil
-	}
-
 	if issue.FilePath() == "" {
 		p.log.Warnf("no file path for the issue: probably a bug inside the linter %q: %#v", issue.FromLinter, issue)
 

diff --git a/pkg/result/processors/invalid_issue_test.go b/pkg/result/processors/invalid_issue_test.go
@@ -31,6 +31,21 @@ func TestInvalidIssue_Process(t *testing.T) {
 				{FromLinter: "typecheck"},
 			},
 		},
+		{
+			desc: "keep only typecheck issues if any exist",
+			issues: []result.Issue{
+				{FromLinter: "typecheck"},
+				{
+					FromLinter: "example",
+					Pos: token.Position{
+						Filename: "test.go",
+					},
+				},
+			},
+			expected: []result.Issue{
+				{FromLinter: "typecheck"},
+			},
+		},
 		{
 			desc: "Go file",
 			issues: []result.Issue{