Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the -s, silent output in case of success the default output #121

Closed
dahankzter opened this issue Jun 19, 2018 · 2 comments
Closed

make the -s, silent output in case of success the default output #121

dahankzter opened this issue Jun 19, 2018 · 2 comments
Labels
no decision No decision to fix or not

Comments

@dahankzter
Copy link
Contributor

When this was implemented there were several people that noted the Unix principle of silence.
I wanted to add this issue as a discussion for making the -s behavior the default.
Possibly also what the rule of silence would mean for Json (and analogously for XML) output where the options discussed so far are basically to return nothing, to return {} and to return {Issues:[]}.

The only practical consideration afaik is backwards compatibility. This is less important early in a project because early adopters are usually not too averse to change. As time goes by this gets more and more important. Backwards compat for the basic text output is also pretty harmless but in the Json case it is easy to see someone parsing the output with jq where the three variants above can potentially result in very different outcomes if the user isn't careful.

What do you think?

@mmatczuk
Copy link

For the record I'm adding my objections as stated in #112

The -s flag:

  • does not solve the Rule of Silence - by default say nothing
  • adds complexity to the tool, another flag now we have -s and -v
  • I do not see a lot of possibilities to reuse it for other things

@frou
Copy link

frou commented Jul 3, 2018

From: #112 (comment)

That would change the current behavior and potentially break someone who for example greps for the congrats message.

Such a grepping person needs to learn sooner or later that the accepted way to check this kind of thing is to examine a process's exit code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no decision No decision to fix or not
Projects
None yet
Development

No branches or pull requests

4 participants