errcheck: allow exclude config without extra file #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the challenges in standardizing on a golangci-lint configuration is that if we want to configure `errcheck`, it requires two separate files to configure: the golangci config file, plus a separate errcheck excludes file. In particular, copying golangci-lint configs across projects often fails, as a reference to an exclude file at a particular file will not resolve. While this config does not add any new functionality, it allows the entirety of the errcheck configuration to be done inside the golangci-lint config file itself.
ldez
requested changes
Jul 10, 2021
|
Thanks for the quick feedback, all comments addressed! Not sure if there's anything I need to do to get the pipeline to pass. It's failing on a |
ldez
approved these changes
Jul 10, 2021
ldez
changed the title
|
Hey, @rliebz — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
|
@rliebz great to see this just land in |
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the challenges in standardizing on a golangci-lint configuration is that if we want to configure
errcheck, it requires two separate files to configure: the golangci config file, plus a separate errcheck excludes file.In particular, copying golangci-lint configs across projects often fails, as a reference to an exclude file at a particular file will not resolve.
While this config does not add any new functionality, it allows the entirety of the errcheck configuration to be done inside the
golangci-lint config file itself.
https://github.com/kisielk/errcheck#excluding-functions