Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logrlint #3093

merged 7 commits into from Aug 22, 2022

feat: add logrlint #3093

merged 7 commits into from Aug 22, 2022


Copy link

logrlint is a linter for go-logr/logr, which lint the number of key value pairs (should be even).

Though I'm not sure whether it's good to add a very specific linter here :(

Copy link

boring-cyborg bot commented Aug 12, 2022

Hey, thank you for opening your first Pull Request !

Copy link

CLAassistant commented Aug 12, 2022

CLA assistant check
All committers have signed the CLA.

@ldez ldez added the linter: new Support new linter label Aug 12, 2022
Copy link

ldez commented Aug 12, 2022

In order for a pull request adding a linter to be reviewed, the linter and the PR must follow some requirements.

Pull Request Description

  • It must have a link to the linter repository.
  • It must provide a short description about the linter.


  • It must not be a duplicate of another linter or a rule of a linter. (the team will help to verify that)
  • It must have a valid license and the file must contain the required information by the license, ex: author, year, etc.
  • The linter repository must have a CI and tests.
  • It must use go/analysis.
  • It must have a valid tag, ex: v1.0.0, v0.1.0.
  • It must not contain init().
  • It must not contain panic(), log.fatal(), os.exit(), or similar.
  • It must not have false positives/negatives. (the team will help to verify that)
  • It must have tests inside golangci-lint.

The Linter Tests Inside Golangci-lint

  • They must have at least one std lib import.
  • They must work with T=<name of the linter test file>.go make test_linters. (the team will help to verify that)


  • The linter must be added to the list of available linters (alphabetical case-insensitive order).
    • enable and disable options
  • If the linter has a configuration, the exhaustive configuration of the linter must be added (alphabetical case-insensitive order)
    • The values must be different from the default ones.
    • The default values must be defined in a comment.
    • The option must have a short description.

Others Requirements

  • The files (tests and linter) inside golangci-lint must have the same name as the linter.
  • The .golangci.yml of golangci-lint itself must not be edited and the linter must not be added to this file.
  • The linters must be sorted in the alphabetical order (case-insensitive) in the Manager.GetAllSupportedLinterConfigs(...) and .golangci.reference.yml.
  • The load mode (WithLoadMode(...)):
    • if the linter doesn't use types: goanalysis.LoadModeSyntax
    • goanalysis.LoadModeTypesInfo required WithLoadForGoAnalysis() in the Manager.GetAllSupportedLinterConfigs(...)
  • The version in WithSince(...) must be the next minor version (v1.X.0) of golangci-lint.


  • The linter should not use SSA. (currently, SSA does not support generics)
  • The linter repository should have a readme and linting.
  • The linter should be published as a binary. (useful to diagnose bug origins)

The golangci-lint team will edit this comment to check the boxes before and during the review.

This checklist does not imply that we will accept the linter.

@ldez ldez self-requested a review August 21, 2022 13:33
@ldez ldez force-pushed the add-logrlint branch 2 times, most recently from a36de60 to 9406328 Compare August 21, 2022 14:58
@ldez ldez changed the title feat: Add logrlint feat: add logrlint Aug 21, 2022
Copy link

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@ldez ldez merged commit f48530e into golangci:master Aug 22, 2022
16 checks passed
@timonwong timonwong deleted the add-logrlint branch August 23, 2022 01:43
Copy link

gabizou commented Aug 31, 2022

@timonwong What made you decide to archive the repository? I see it's been moved to a new one, but it makes for an annoying set of changes to golangci-lint to get a dependency update now...

Copy link

ldez commented Aug 31, 2022

@gabizou #3144

Copy link

Hi, sorry for the late comment.
It appears is "archived." I learned about this via trying to report an issue with logrlint not supporting (or not working corectly) with variadic functions:

logger/logger.go:54:28: odd number of arguments passed as key-value pairs for logging (logrlint)
        l.V(DebugLevel).Info(msg, keysAndValues...)

What's the proper course to address this issue?

Copy link

A follow-up (related) question - should golangci-lint use (support) linters from the "archived" GitHub repos?

Copy link

ldez commented Sep 9, 2022


SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
Co-authored-by: Fernandez Ludovic <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
linter: new Support new linter
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants