Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depguard config in yml #880

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Fix depguard config in yml #880

merged 1 commit into from
Dec 29, 2019

Conversation

pohang
Copy link
Contributor

@pohang pohang commented Dec 3, 2019

This PR fixes the following issues:

* 'linters-settings.Depguard.packages-with-error-message[github]' expected type 'string', got unconvertible type 'map[string]interface {}'

since alot of package names will have dots in them. A workaround is to specify as a list of maps, which will get merged by mapstructure (see config). Viper does have WeaklyTypedInput enabled by default.

@claassistantio
Copy link

claassistantio commented Dec 3, 2019

CLA assistant check
All committers have signed the CLA.

@tpounds tpounds added bug Something isn't working area: config Related to .golangci.yml and/or cli options labels Dec 10, 2019
@tpounds
Copy link
Contributor

tpounds commented Dec 10, 2019

@pohang Thanks for the contribution! Can you make your updates to README.tmpl.md and rerun with make README.md and then add both files to the pr?

@pohang
Copy link
Contributor Author

pohang commented Dec 10, 2019

@tpounds All the changes to README.tmpl.md come from updating the two .yml files and then running make README.md. I don't think that updating README.tmpl.md is necessary here.

Copy link
Contributor

@tpounds tpounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 it!

@tpounds tpounds merged commit 06dddc3 into golangci:master Dec 29, 2019
@tpounds
Copy link
Contributor

tpounds commented Dec 29, 2019

@pohang My mistake. It looks like the tests were failing for an unrelated issue. I've merged in your commit. Thanks!

@ldez ldez added this to the v1.22 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to .golangci.yml and/or cli options bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants