-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom PubSubEngine for GraphQL PubSub #422
Comments
Good call. Will take a crack at it this week. |
This was referenced Oct 6, 2020
@goldcaddy77 what is the status of this issue? |
Hi @metmirr , this is not implemented yet. If you want to put in a PR I'm happy to review and get it integrated. |
dzhelezov
added a commit
to dzhelezov/warthog
that referenced
this issue
Feb 17, 2021
goldcaddy77
pushed a commit
that referenced
this issue
Mar 24, 2021
This has been implemented. See https://github.com/goldcaddy77/warthog/blob/main/src/core/server.ts#L185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default ApolloServer uses an EventEmitter-based PubSubEngine, and in general it is recommended to use a more scalable (like Redis-based) one. However, it doesn't seem to be possible to provide a custom implementation since as the
pubSub
implementation should be passed to thebuildSchema
call here :warthog/src/core/server.ts
Line 161 in b464981
Here's a relevant example from
type-graphql
:https://github.com/MichalLytek/type-graphql/blob/d5e3403f7610ce8f53b919a3dd490806685570c7/examples/redis-subscriptions/index.ts#L27
The text was updated successfully, but these errors were encountered: