-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebKit is deprecated #1081
Comments
It is not such simple. Maybe sometime or some later... |
Arch Linux package is built with Qt 5.11: PKGBUILD. |
This Qt WebKit issue has been reported and mentioned many times. For example: #677, #1316. Perhaps porting GoldenDict to Qt6 should be combined with a port to Qt WebEngine and C++17. A lot of obsolete Qt4, Qt5 and C++03 code could be removed. And the rest of the code could be brought up to modern C++. The qt4x5 version could be maintained for a time as a legacy/stable version/branch. |
GoldenDict-x86_64.AppImage Qt/6.2+ Linux (2021-08-15) GoldenDict-x86_64.AppImage
|
The corresponding pull request is missing or closed though. Is the distributed binary based on #1400's branch? |
also, any chance we could get a windows binary with this? it would likely solve a lot of problems for people using online dictionaries within goldendict extensively. |
[2021-08-24]GoldenDict Qt/6.2 QtWebEngine [Linux/Windows] GoldenDict.zip
|
oh wow, good news indeed! ty! |
@adarmstrng Indeed good news! I hope Qt 6.2 to be released in Sept. and my distributive (Arch Linux) will package it timely, so I could try AppImage. Also, I wish the author sending changes back upstream or actively maintain their own fork. |
The fork's code seems unavailable, which violates the GPL. The binaries compiled from unknown sources could contain malware. |
I did compile GD with QtWebEngine from fork made by author of PR #1400. |
I've added |
I did try it.
|
|
new log and picture |
You could ask the author of the PR in a comment to #1400. I doubt the author monitors this issue. |
@xiaoyifang, please check this bug #1081 (comment) |
seems like some js error which I still trying to fix ,
|
I confirm that port to QtWebEngine works. Only when trying to search it hangs. |
does it hangs when you used the old goldendict version . |
What is the new one?
It doesn't help at all. |
I mean the version withouth webengine. |
Version |
@perfect7gentleman can you build with the newest code #1400 and have a try ,to check if the hangs still existed. |
I wrote some time ago that it works now. #1400 (comment) |
sorry to bump the old thread, but is it possible to use QTextBrowser? QtWebEngine is HUGE and take up a lot of memory and disk space. |
Porting to Qt WebEngine is hard and time-consuming enough. |
The current github code of goldendict builds against webkitwidgets which uses QtWebkit.
But QtWebkit is deprecated. As goldendict doesn't build with qt > 5.9 (as qtwebkit got removed), Is there any plan to port it to qtwebengine?
The text was updated successfully, but these errors were encountered: