Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoldenDict can't handle certain dictionary filenames #30

Closed
Tvangeste opened this issue Jul 28, 2011 · 2 comments
Closed

GoldenDict can't handle certain dictionary filenames #30

Tvangeste opened this issue Jul 28, 2011 · 2 comments
Labels
Milestone

Comments

@Tvangeste
Copy link
Member

At least on Windows. Let's say, I have a Russian locale. And any dictionary's file name with umlauts is completely ignored by GD.

For example, testüö.dsl, or test朗.dsl. Looks like GD stores all the dictionary file names in standard strings, first converting to them via toLocal8Bit(), which can't handle those symbols that are outside of the current locale.

There are some comment notes in dictionary.cc about desire to be Qt-neutral and not using any Qt stuff, but the code still has some Qt dependencies already. Maybe, the names should be stored as QStrings then?

@Tvangeste
Copy link
Member Author

Or, maybe we should just always use toUtf8() and fromUtf8() to convert filenames to byte arrays and back on Windows? That seem to be a better option: no need to tie with qt, no need to rewrite stuff... :)

Abs62 added a commit to Abs62/goldendict that referenced this issue Sep 9, 2011
Abs62 added a commit that referenced this issue Oct 22, 2011
Use file names in UTF-8. Fix issue #30.
@Abs62
Copy link
Member

Abs62 commented Oct 22, 2011

Fixed in commit 2763b74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants