You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At least on Windows. Let's say, I have a Russian locale. And any dictionary's file name with umlauts is completely ignored by GD.
For example, testüö.dsl, or test朗.dsl. Looks like GD stores all the dictionary file names in standard strings, first converting to them via toLocal8Bit(), which can't handle those symbols that are outside of the current locale.
There are some comment notes in dictionary.cc about desire to be Qt-neutral and not using any Qt stuff, but the code still has some Qt dependencies already. Maybe, the names should be stored as QStrings then?
The text was updated successfully, but these errors were encountered:
Or, maybe we should just always use toUtf8() and fromUtf8() to convert filenames to byte arrays and back on Windows? That seem to be a better option: no need to tie with qt, no need to rewrite stuff... :)
Abs62
added a commit
to Abs62/goldendict
that referenced
this issue
Sep 9, 2011
At least on Windows. Let's say, I have a Russian locale. And any dictionary's file name with umlauts is completely ignored by GD.
For example,
testüö.dsl
, ortest朗.dsl
. Looks like GD stores all the dictionary file names in standardstring
s, first converting to them viatoLocal8Bit()
, which can't handle those symbols that are outside of the current locale.There are some comment notes in
dictionary.cc
about desire to be Qt-neutral and not using any Qt stuff, but the code still has some Qt dependencies already. Maybe, the names should be stored asQString
s then?The text was updated successfully, but these errors were encountered: