Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl support in latest windows git build: wrong scrollbar alignment in the wordlist #384

Closed
zandgreen opened this issue Aug 18, 2013 · 9 comments
Assignees
Labels
Milestone

Comments

@zandgreen
Copy link

Thanks to the advanced rtl support in the GoldenDict 1.5.0-RC-98-g46bbe67, we have right side alignment in the wordlist under the searchbar but..

there is a problem with the horizontal scrollbar alignment in the wordlist as it is aligned to the left side which makes disappear all the words if the list contains a longer search combination.

In other words the scrollbar horizontal gravity is set to the left while for the rtl languages it should be set to the right.

I'll provide screenshorts if needed.

@Tvangeste
Copy link
Member

Yes, please provide the screenshots. If you could, please make screenshots in both wordlist modes (use Ctrl+S to switch).

@zandgreen
Copy link
Author

So, here are the screenshorts, as you may see we can't see the words in the wordlist as the horizontal scrollbar is slid to the end of the longest found combination and it should be aligned by the right side.

goldendict 1 5 0-rc-98-g46bbe67_2
goldendict 1 5 0-rc-98-g46bbe67

@ghost ghost assigned Abs62 Aug 20, 2013
@Tvangeste
Copy link
Member

@Abs62, will you be able to look at it in 1.5 timeframe (i.e, in August)?

@Abs62
Copy link
Member

Abs62 commented Aug 29, 2013

Hm. In general case word lists (especially hystory list) can contain both rtl and ltr words. How we must handle this case?

@zandgreen
Copy link
Author

@Abs62, That's a good point! As for the history list, there is no horizontal scroll (only "..." showing that there are more characters) so we should make visible a beginning of each string whether it's rtl or ltr. The example of incorrect display:

alignment

The short rtl words are aligned to the right and are displayed correctly but for the longer one (the first in the list) which we can see only the end.

@chulai
Copy link
Member

chulai commented Sep 13, 2013

@zandgreen, can you test the last Release Candidate version, GoldenDict 1.5.0-RC-156-g8a20ec7, that includes above change made by Abs62? Download it from the following page: https://github.com/goldendict/goldendict/wiki/Early-Access-Builds-for-Windows

@zandgreen
Copy link
Author

@chulai, looks like both issues have been solved in the latest RC. Rtl lines are displayed correctly in the wordlist and history boxes.

history

@Tvangeste
Copy link
Member

Excellent, thanks for verification.

@zandgreen
Copy link
Author

Thanks for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants