-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtl support in latest windows git build: wrong scrollbar alignment in the wordlist #384
Comments
Yes, please provide the screenshots. If you could, please make screenshots in both wordlist modes (use |
@Abs62, will you be able to look at it in 1.5 timeframe (i.e, in August)? |
Hm. In general case word lists (especially hystory list) can contain both rtl and ltr words. How we must handle this case? |
@Abs62, That's a good point! As for the history list, there is no horizontal scroll (only "..." showing that there are more characters) so we should make visible a beginning of each string whether it's rtl or ltr. The example of incorrect display: The short rtl words are aligned to the right and are displayed correctly but for the longer one (the first in the list) which we can see only the end. |
@zandgreen, can you test the last Release Candidate version, GoldenDict 1.5.0-RC-156-g8a20ec7, that includes above change made by Abs62? Download it from the following page: https://github.com/goldendict/goldendict/wiki/Early-Access-Builds-for-Windows |
@chulai, looks like both issues have been solved in the latest RC. Rtl lines are displayed correctly in the wordlist and history boxes. |
Excellent, thanks for verification. |
Thanks for everyone. |
Thanks to the advanced rtl support in the GoldenDict 1.5.0-RC-98-g46bbe67, we have right side alignment in the wordlist under the searchbar but..
there is a problem with the horizontal scrollbar alignment in the wordlist as it is aligned to the left side which makes disappear all the words if the list contains a longer search combination.
In other words the scrollbar horizontal gravity is set to the left while for the rtl languages it should be set to the right.
I'll provide screenshorts if needed.
The text was updated successfully, but these errors were encountered: