Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send messages to appropriate streams #145

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Send messages to appropriate streams #145

merged 1 commit into from
Mar 15, 2017

Conversation

goldmann
Copy link
Owner

INFO goes to stdout, everything else goes to stderr

Fixes #144

INFO goes to stdout, everything else goes to stderr

Fixes #144
@goldmann
Copy link
Owner Author

@l-d-j Any opinions?

@rwngwn
Copy link

rwngwn commented Mar 14, 2017

I dont mind - but tbh i think any app should rely on exit code - not random stuff in err out :)

@goldmann
Copy link
Owner Author

@l-d-j Yes, I agree fully with you. Automated systems should use exit code or (if this is a Python tool) - use the squash tool directly, as a library.

@goldmann goldmann merged commit 77c1ca3 into master Mar 15, 2017
@goldmann goldmann deleted the gh-144-stderr branch March 15, 2017 10:55
praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Nov 30, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Nov 30, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Nov 30, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Dec 4, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Dec 4, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Dec 5, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version (or play with FD
redirection).

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to sclorg/container-common-scripts that referenced this pull request Dec 5, 2018
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version (or play with FD
redirection).

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants